[query] Use valid globals reference in MWZJ and TABK #14246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG: Fix a bug, introduced in 0.2.114, in which `Table.multi_way_zip_join` and `Table.aggregate_by_key` could throw "NoSuchElementException: Ref with name __iruid_..." when one or more of the tables had a number of partitions substantially different from the desired number of output partitions. Fixes hail-is#14245. In both MultiWayZipJoin and TableAggregateByKey, we repartition the child but neglect to use the new globals `Ref` from the repartitioned child. As long as `repartitionNoShuffle` does not create a new TableStage with new globals, this is fine, but that is not, in general, true. It seems that recently, in lowered backends, when the repartition cost is deemed "high" we generate a fresh TableStage with a fresh globals ref.
ehigham
approved these changes
Feb 2, 2024
|
|
||
| repartitioned.mapPartition(Some(child.typ.key)) { partition => | ||
| Let( | ||
| FastSeq("global" -> repartitioned.globals), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Fix a bug, introduced in 0.2.114, in which
Table.multi_way_zip_joinandTable.aggregate_by_keycould throw "NoSuchElementException: Ref with name__iruid_..." when one or more of the tables had a number of partitions substantially different from the desired number of output partitions.Fixes #14245.
In both MultiWayZipJoin and TableAggregateByKey, we repartition the child but neglect to use the new globals
Reffrom the repartitioned child. As long asrepartitionNoShuffledoes not create a new TableStage with new globals, this is fine, but that is not, in general, true. It seems that recently, in lowered backends, when the repartition cost is deemed "high" we generate a fresh TableStage with a fresh globals ref.