[pip] Move protobuf pin from query to gear - #14393
Merged
hail-ci-robot merged 1 commit intoMar 5, 2024
Merged
Conversation
daniel-goldstein
force-pushed
the
remove-protobuf-pin-v2
branch
from
March 4, 2024 21:34
391edb3 to
bf2e5d3
Compare
patrick-schultz
approved these changes
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobufwas pinned not because it is a direct dependency ofhailbut because the version ofgoogle-cloud-profilerthat we use is incompatible with greater versions of protobuf despite not putting an upper bound on its pin. However, the current solution of pinning it inhailtop/requirements.txtandpython/requirements.txtis problematic in three ways:hailpip package cannot use a newer version of protobuf if they want toprotobufversion is only a problem forgoogle-cloud-profiler, which we only use in the batch/ci/auth services, not the hail packageprotobufno longer a transitive dependency of anything inhailtop/hail, so why include it (and why include it twice?)This is all fixable by moving the
protobufpin "up" togear/requirements.txt, where we also installgoogle-cloud-profiler. Whether or not we should be upgradinggoogle-cloud-profilerto remove theprotobufpin is a valid but unfortunately thornier issue sincegoogle-cloud-profilerstatically linking libc breakslibsass. This allows us to punt on that upgrade while freeing users of theprotobufrestriction.