Skip to content

[query] Load each missing byte once during struct decoding. #14406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2024
Merged

[query] Load each missing byte once during struct decoding. #14406

merged 2 commits into from
Mar 15, 2024

Conversation

chrisvittal
Copy link
Collaborator

@chrisvittal chrisvittal commented Mar 12, 2024 •
edited
Loading

Resolves #13811

@chrisvittal
Copy link
Collaborator Author

Could try to do this an int or long at a time too.

@chrisvittal chrisvittal requested a review from ehigham March 12, 2024 16:43
@chrisvittal chrisvittal force-pushed the query/optimize-struct-decoding branch from dcbd9f1 to f0746a8 Compare March 15, 2024 19:57
@chrisvittal chrisvittal force-pushed the query/optimize-struct-decoding branch from f0746a8 to 78ac0d5 Compare March 15, 2024 20:03
@hail-ci-robot hail-ci-robot merged commit 858dd08 into hail-is:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehigham ehigham ehigham approved these changes

Assignees

@ehigham ehigham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[query] load each missingness byte once when decoding a struct
3 participants
@chrisvittal @ehigham @hail-ci-robot