[dataproc] adds project to args for submit #14619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if you try to pass `--project` to `hailctl dataproc submit`, it still tries to use the project configured via `gcloud config`, and passes through the value specified for `--project` in the `pass_through_args`. This change allows the user to specify which project their Dataproc cluster is in as part of the command. An example command where the project is ignored on `main` but used correctly on this branch is: ```bash hailctl dataproc submit test.py --region us-central1 --project broad-ctsa ```
chrisvittal
approved these changes
Jul 29, 2024
patrick-schultz
previously requested changes
Jul 31, 2024
Member
patrick-schultz
left a comment
patrick-schultz
left a comment
There was a problem hiding this comment.
PRs need to link to issues now. If there isn't one already, can you make an issue that describes the problem, and link it from here?
Contributor
Author
|
Good catch, updated! |
patrick-schultz
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14647.