[qob,batch] Add cost to BatchProgressBar

[jigold]

Change Description

Adds cost information to the progress bar

Security Assessment

• This change has no security impact

Impact Description

Client-side change only

(Reviewers: please confirm the security impact before approving)

[jigold]

Can someone copy and paste the error here? Or get me the test failure in a different way if it's long?

[jigold]

This looks like it's passing now :)

[chrisvittal]

Thanks Jackie! The only failures you're getting now are lint errors, you'll need to ruff format your code. Then it should be fully green.

[jigold]

check-hail-fast is telling me everything is broken. Can you give me the specific error?

[chrisvittal]

ruff format hail --diff
--- hail/python/hailtop/batch_client/aioclient.py
+++ hail/python/hailtop/batch_client/aioclient.py
@@ -507,7 +507,9 @@
         else:
             description += url
 
-        with progress.with_task(description, total=status['n_jobs'], disable=disable_progress_bar, cost=status['cost']) as progress_task:
+        with progress.with_task(
+            description, total=status['n_jobs'], disable=disable_progress_bar, cost=status['cost']
+        ) as progress_task:
             while True:
                 status = await self.status()
                 progress_task.update(None, total=status['n_jobs'], completed=status['n_completed'], cost=status['cost'])
@@ -706,7 +708,10 @@
             while True:
                 status = await self.status()
                 progress_task.update(
-                    None, total=status['n_jobs'] - starting_job + 1, completed=status['n_completed'] - starting_job + 1, cost=status['cost']
+                    None,
+                    total=status['n_jobs'] - starting_job + 1,
+                    completed=status['n_completed'] - starting_job + 1,
+                    cost=status['cost'],
                 )
                 if status['complete']:
                     return status

1 file would be reformatted, 461 files already formatted

[jigold]

Can someone check whether this worked now? It looks like there needs to be 2 approvals now?

[jigold]

Could someone please post the new error? Thanks!

[chrisvittal]

Just lints. Fixed.

[patrick-schultz]

This should be a nice qol improvement. Thanks Jackie!