[compiler] fix RIterable#14913
Merged
Merged
Conversation
chrisvittal
approved these changes
Jun 10, 2025
chrisvittal
left a comment
chrisvittal
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks for the fix.
patrick-schultz
force-pushed
the
ps/push-vnzsokvkonvq
branch
from
a611668 to
ee44f0a
Compare
patrick-schultz
force-pushed
the
ps/push-vnzsokvkonvq
branch
from
ee44f0a to
371403c
Compare
ehigham
approved these changes
Jun 12, 2025
ehigham
left a comment
ehigham
left a comment
Member
There was a problem hiding this comment.
Looks great - a prime example of why inheritance is evil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes an apparently long standing bug. The issue is that
RDictwas a subclass of the concrete classRIterable, and assumed that allTypeWithRequirements corresponding to a dict are explicitly constructed as theRDictsubclass. However,SContainer._typeWithRequirednessalways constructs anRIterable, even though it may be a dict type.To fix, I eliminated the questionable use of inheritance.
RIterableis now final,RDictis deleted in favor of being a special case ofRIterable, andRNDArray(which was also a subclass ofRIterable, even thoughTNDArrayis not aTIterable) no longer inherits fromRIterable.Security Assessment