[query] add methods for (multivariate) hypergeometric distribution - #14923
Merged
Conversation
patrick-schultz
force-pushed
the
ps/push-xkyzvoqqmzov
branch
from
June 17, 2025 19:13
51cebf2 to
a16addb
Compare
patrick-schultz
force-pushed
the
ps/push-xkyzvoqqmzov
branch
from
June 18, 2025 14:34
a16addb to
fd6c1a9
Compare
patrick-schultz
marked this pull request as ready for review
June 18, 2025 14:35
chrisvittal
approved these changes
Jun 18, 2025
chrisvittal
left a comment
chrisvittal
left a comment
Collaborator
There was a problem hiding this comment.
Straightforward change, extends statistics functionality with very little new
maintenance burden.
ehigham
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds methods to sample from a hypergeometric and multivariate hypergeometric distribution (
rand_hyperandrand_multi_hyper), as well as a function to evaluate the probability function of a hypergeometric distribution (phyper). I chose a parameterization consistent with scipy. I believe the included doctests are sufficient to test these methods, which simply expose library methods.Security Assessment