Skip to content

[query] fix job group state polling - #15119

Merged
hail-ci-robot merged 2 commits into
hail-is:mainfrom
ehigham:ehigham/fix-qob-job-group-cancellation
Sep 29, 2025
Merged

hail-ci-robot merged 2 commits into
hail-is:mainfrom
ehigham:ehigham/fix-qob-job-group-cancellation

Conversation

@ehigham

@ehigham ehigham commented Sep 26, 2025

Copy link
Copy Markdown
Member

Fixes #15118

This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP

@ehigham
ehigham force-pushed the ehigham/fix-qob-job-group-cancellation branch from 3a3c2d4 to 25cc19f Compare September 26, 2025 20:53

if (jobGroup.complete)
return jobGroup
if (jobGroup.state != JobGroupStates.Running) return jobGroup

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these enumerated anywhere? Are we sure there's not a Ready?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  case object Failure extends JobGroupState
  case object Cancelled extends JobGroupState
  case object Success extends JobGroupState
  case object Running extends JobGroupState

... yes

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are reimplemented from batch/front_end.py. fwiw I don't like this solution and feels fragile.

@cjllanwarne cjllanwarne left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Ed!

@ehigham
ehigham force-pushed the ehigham/fix-qob-job-group-cancellation branch from 1a24855 to 605caea Compare September 29, 2025 15:14
@ehigham
ehigham requested a review from chrisvittal September 29, 2025 15:25
@hail-ci-robot
hail-ci-robot merged commit e8b6f95 into hail-is:main Sep 29, 2025
@ehigham
ehigham deleted the ehigham/fix-qob-job-group-cancellation branch September 29, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[query] query driver polls cancelled job group indefinitely

4 participants