Repository navigation
[query] fix job group state polling - #15119
Merged
hail-ci-robot merged 2 commits intoSep 29, 2025
Merged
Conversation
ehigham
force-pushed
the
ehigham/fix-qob-job-group-cancellation
branch
from
September 26, 2025 20:53
3a3c2d4 to
25cc19f
Compare
cjllanwarne
reviewed
Sep 26, 2025
|
|
||
| if (jobGroup.complete) | ||
| return jobGroup | ||
| if (jobGroup.state != JobGroupStates.Running) return jobGroup |
Collaborator
There was a problem hiding this comment.
Are these enumerated anywhere? Are we sure there's not a Ready?
Collaborator
There was a problem hiding this comment.
case object Failure extends JobGroupState
case object Cancelled extends JobGroupState
case object Success extends JobGroupState
case object Running extends JobGroupState
... yes
Member
Author
There was a problem hiding this comment.
These are reimplemented from batch/front_end.py. fwiw I don't like this solution and feels fragile.
cjllanwarne
approved these changes
Sep 26, 2025
cjllanwarne
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks Ed!
ehigham
force-pushed
the
ehigham/fix-qob-job-group-cancellation
branch
from
September 29, 2025 15:14
1a24855 to
605caea
Compare
chrisvittal
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15118
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP