New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatten py in lmm #4606

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@jbloom22
Collaborator

jbloom22 commented Oct 22, 2018

No description provided.

@tpoterba

This comment has been minimized.

Collaborator

tpoterba commented Oct 23, 2018

what does this do?

@jbloom22

This comment has been minimized.

Collaborator

jbloom22 commented Oct 23, 2018

changes (n, 1)-array to (n)-array

@tpoterba

This comment has been minimized.

Collaborator

tpoterba commented Oct 23, 2018

does it fix a bug? can we test it?

@jbloom22

This comment has been minimized.

Collaborator

jbloom22 commented Oct 23, 2018

Yes, it fixes a bug that resulted in a failed check on the dimension of y. I've added a regression test.

http://discuss.hail.is/t/breaking-change-hail-0-2-removed-kinshipmatrix-linear-mixed-regression/578/16

@danking danking merged commit 80357ef into hail-is:master Oct 23, 2018

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment