Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blockmatrix sparse sum bug #4888

Merged
merged 1 commit into from Dec 4, 2018
Merged

Conversation

@jbloom22
Copy link
Contributor

@jbloom22 jbloom22 commented Dec 4, 2018

Summing a block-sparse matrix may result in a block-dense vector, in which case maybeBlocks should be None (otherwise the bis.length < maxNBlocks assert fails...when rebuilding BlockMatrix in Python/C++ I may change the invariants).

Also extended test cases to serve as regression test.

@jbloom22 jbloom22 force-pushed the blockmatrix_sum_bugfix branch from 2057534 to f682d92 Dec 4, 2018
@danking danking merged commit f3fecf8 into hail-is:master Dec 4, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants