Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import_plink contig_recoding defaults #4926

Merged
merged 3 commits into from Dec 7, 2018

Conversation

jigold
Copy link
Collaborator

@jigold jigold commented Dec 7, 2018

Fixes #4925.

Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, but one possible orthogonal enhancement

@@ -1631,7 +1628,10 @@ def import_plink(bed, bim, fam,

contig_recoding : :obj:`dict` of :obj:`str` to :obj:`str`, optional
Dict of old contig name to new contig name. The new contig name must be
in the reference genome given by ``reference_genome``.
in the reference genome given by ``reference_genome``. If ``None``, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not totally in-scope, but can we add a warning above that if you have GRCh38, PLINK probably encodes your data as 1, 2, 3 and needs a recoding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, should we just use this as the default recoding?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine to me.

@danking danking merged commit b9537d1 into hail-is:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants