Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import_plink contig_recoding defaults #4926

Merged
merged 3 commits into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@jigold
Copy link
Collaborator

commented Dec 7, 2018

Fixes #4925.

@tpoterba
Copy link
Collaborator

left a comment

looks great, but one possible orthogonal enhancement

@@ -1631,7 +1628,10 @@ def import_plink(bed, bim, fam,
contig_recoding : :obj:`dict` of :obj:`str` to :obj:`str`, optional
Dict of old contig name to new contig name. The new contig name must be
in the reference genome given by ``reference_genome``.
in the reference genome given by ``reference_genome``. If ``None``, the

This comment has been minimized.

Copy link
@tpoterba

tpoterba Dec 7, 2018

Collaborator

not totally in-scope, but can we add a warning above that if you have GRCh38, PLINK probably encodes your data as 1, 2, 3 and needs a recoding?

This comment has been minimized.

Copy link
@tpoterba

tpoterba Dec 7, 2018

Collaborator

actually, should we just use this as the default recoding?

This comment has been minimized.

Copy link
@jigold

jigold Dec 7, 2018

Author Collaborator

That seems fine to me.

fix

@danking danking merged commit b9537d1 into hail-is:master Dec 7, 2018

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.