Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary option to export rectangles #5046

Merged
merged 5 commits into from Jan 2, 2019

Conversation

jbloom22
Copy link
Contributor

@jbloom22 jbloom22 commented Dec 27, 2018

@danking I rebased in the process of addressing your requested changes, so git won't allow me to re-open the closed branch #4842. I think this is now safe with regard to closing resources. Do you see a way to not include the branch on binary twice? I'd prefer to consider changing the types of streams/buffers as another PR.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could contort the code to avoid the cast, but IMHO, this is pretty legible as written. Resources are handled correctly with write file and using.

We can punt on the buffering issues. I suppose a lot of this will be re-written in C++ shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants