Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add binary option to export rectangles #5046
@danking I rebased in the process of addressing your requested changes, so git won't allow me to re-open the closed branch #4842. I think this is now safe with regard to closing resources. Do you see a way to not include the branch on binary twice? I'd prefer to consider changing the types of streams/buffers as another PR.
danking left a comment
We could contort the code to avoid the cast, but IMHO, this is pretty legible as written. Resources are handled correctly with write file and using.
We can punt on the buffering issues. I suppose a lot of this will be re-written in C++ shortly.