Skip to content

Fix make_table separator issue#5088

Merged
danking merged 2 commits intohail-is:masterfrom
tpoterba:fix-make-table
Jan 9, 2019
Merged

Fix make_table separator issue#5088
danking merged 2 commits intohail-is:masterfrom
tpoterba:fix-make-table

Conversation

@tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Jan 7, 2019

Cotton broke this when he converted make_table to Python

cseed
cseed previously requested changes Jan 9, 2019
Copy link
Contributor

@cseed cseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test.

@tpoterba
Copy link
Contributor Author

tpoterba commented Jan 9, 2019

oops, I thought make_table was experimental. guess not.

Copy link
Contributor

@cseed cseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even experimental tests are good!

@cseed
Copy link
Contributor

cseed commented Jan 9, 2019

... so I don't break it again.

@tpoterba
Copy link
Contributor Author

tpoterba commented Jan 9, 2019

👹

@danking danking merged commit 60f1f93 into hail-is:master Jan 9, 2019
@tpoterba tpoterba deleted the fix-make-table branch January 9, 2019 20:57
@tpoterba tpoterba restored the fix-make-table branch November 7, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants