Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make_table separator issue #5088

Merged
merged 2 commits into from Jan 9, 2019
Merged

Fix make_table separator issue #5088

merged 2 commits into from Jan 9, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Jan 7, 2019

Cotton broke this when he converted make_table to Python

Copy link
Collaborator

@cseed cseed left a comment

This needs a test.

Loading

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Jan 9, 2019

oops, I thought make_table was experimental. guess not.

Loading

@tpoterba tpoterba dismissed cseed’s stale review Jan 9, 2019

addressed

cseed
cseed approved these changes Jan 9, 2019
Copy link
Collaborator

@cseed cseed left a comment

Even experimental tests are good!

Loading

@cseed
Copy link
Collaborator

@cseed cseed commented Jan 9, 2019

... so I don't break it again.

Loading

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Jan 9, 2019

👹

Loading

@danking danking merged commit 60f1f93 into hail-is:master Jan 9, 2019
1 check passed
Loading
@tpoterba tpoterba deleted the fix-make-table branch Jan 9, 2019
@tpoterba tpoterba restored the fix-make-table branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants