Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make_table separator issue #5088

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@tpoterba
Copy link
Collaborator

commented Jan 7, 2019

Cotton broke this when he converted make_table to Python

@cseed
Copy link
Collaborator

left a comment

This needs a test.

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

oops, I thought make_table was experimental. guess not.

addressed

@cseed

cseed approved these changes Jan 9, 2019

Copy link
Collaborator

left a comment

Even experimental tests are good!

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

... so I don't break it again.

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

👹

@danking danking merged commit 60f1f93 into hail-is:master Jan 9, 2019

1 check passed

hail-ci-0-1 successful build
Details

@tpoterba tpoterba deleted the tpoterba:fix-make-table branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.