Fix escaping of some edge identifiers like '$' #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoterba
commented
Jan 14, 2019
| @@ -215,7 +215,7 @@ package object utils extends Logging | |||
| .filter(s => !s.isEmpty) | |||
|
|
|||
| def prettyIdentifier(str: String): String = { | |||
| if (str.matches("""\p{javaJavaIdentifierStart}\p{javaJavaIdentifierPart}*""")) | |||
| if (str.matches("""[_a-zA-Z]\w*""")) | |||
There was a problem hiding this comment.
this is much more conservative. There is no reason to use the java identifier stuff if we don't have a good idea what's in it -- apparently "currency" characters are valid identifier starts!
tpoterba
commented
Jan 14, 2019
| @@ -178,7 +178,10 @@ def unescape_parsable(s): | |||
|
|
|||
|
|
|||
| def escape_id(s): | |||
| return Env.jutils().escapeIdentifier(s) | |||
| if re.fullmatch(r'[_a-zA-Z]\w*', s): | |||
There was a problem hiding this comment.
avoid some JVM trips
danking
approved these changes
Jan 14, 2019
|
The rest of the stack does handle weird named fields, the problem was that this wasn't getting escaped correctly (well, that our python type parser had different assumptions about escaping than the string escaper). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5119