Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] let #5154

Merged
merged 7 commits into from Jan 23, 2019
Merged

[hail] let #5154

merged 7 commits into from Jan 23, 2019

Conversation

@danking
Copy link
Collaborator

@danking danking commented Jan 16, 2019

No description provided.

@@ -331,6 +331,41 @@ def bind(f: Callable, *exprs):
return construct_expr(res_ir, lambda_result.dtype, indices, aggregations)


def let(**exprs):
Copy link
Collaborator

@tpoterba tpoterba Jan 16, 2019

this should be (*exprs) right?

Copy link
Collaborator Author

@danking danking Jan 16, 2019

fixed

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Jan 16, 2019

I'm a bit worried about confusing people with two (almost) identical methods named differently.

What do you think about something like rbind for right-bind? Then it's clear they're in the same family

Copy link
Collaborator

@tpoterba tpoterba left a comment

add to hail.expr.init, as well as functions/index.rst and functions/core.rst

@danking danking dismissed tpoterba’s stale review Jan 16, 2019

done, though I formally register my disappointment that we aren't using let

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Jan 17, 2019

happy to rename to let in 0.3

@danking danking merged commit 4f10cf5 into hail-is:master Jan 23, 2019
1 check passed
@danking danking deleted the let branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants