Merged
Conversation
tpoterba
reviewed
Jan 16, 2019
| return construct_expr(res_ir, lambda_result.dtype, indices, aggregations) | ||
|
|
||
|
|
||
| def let(**exprs): |
Contributor
There was a problem hiding this comment.
this should be (*exprs) right?
Contributor
|
I'm a bit worried about confusing people with two (almost) identical methods named differently. What do you think about something like |
tpoterba
previously requested changes
Jan 16, 2019
Contributor
tpoterba
left a comment
tpoterba
left a comment
There was a problem hiding this comment.
add to hail.expr.init, as well as functions/index.rst and functions/core.rst
danking
dismissed
tpoterba’s stale review
done, though I formally register my disappointment that we aren't using let
Contributor
|
happy to rename to |
tpoterba
approved these changes
Jan 17, 2019
This was referenced Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.