Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] let #5154

Merged
merged 7 commits into from
Jan 23, 2019
Merged

[hail] let #5154

merged 7 commits into from
Jan 23, 2019

Conversation

danking
Copy link
Contributor

@danking danking commented Jan 16, 2019

No description provided.

@@ -331,6 +331,41 @@ def bind(f: Callable, *exprs):
return construct_expr(res_ir, lambda_result.dtype, indices, aggregations)


def let(**exprs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be (*exprs) right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@tpoterba
Copy link
Contributor

I'm a bit worried about confusing people with two (almost) identical methods named differently.

What do you think about something like rbind for right-bind? Then it's clear they're in the same family

Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to hail.expr.init, as well as functions/index.rst and functions/core.rst

@danking danking dismissed tpoterba’s stale review January 16, 2019 17:05

done, though I formally register my disappointment that we aren't using let

@tpoterba
Copy link
Contributor

happy to rename to let in 0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants