Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] let #5154

Merged
merged 7 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@danking
Copy link
Collaborator

commented Jan 16, 2019

No description provided.

@@ -331,6 +331,41 @@ def bind(f: Callable, *exprs):
return construct_expr(res_ir, lambda_result.dtype, indices, aggregations)


def let(**exprs):

This comment has been minimized.

Copy link
@tpoterba

tpoterba Jan 16, 2019

Collaborator

this should be (*exprs) right?

This comment has been minimized.

Copy link
@danking

danking Jan 16, 2019

Author Collaborator

fixed

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

I'm a bit worried about confusing people with two (almost) identical methods named differently.

What do you think about something like rbind for right-bind? Then it's clear they're in the same family

@tpoterba
Copy link
Collaborator

left a comment

add to hail.expr.init, as well as functions/index.rst and functions/core.rst

danking added some commits Jan 16, 2019

done, though I formally register my disappointment that we aren't using let

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2019

happy to rename to let in 0.3

danking added some commits Jan 23, 2019

@danking danking merged commit 4f10cf5 into hail-is:master Jan 23, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.