Skip to content

Plot utils#5251

Merged
danking merged 4 commits intohail-is:masterfrom
cseed:plot-utils
Feb 7, 2019
Merged

Plot utils#5251
danking merged 4 commits intohail-is:masterfrom
cseed:plot-utils

Conversation

@cseed
Copy link
Contributor

@cseed cseed commented Feb 5, 2019

I'm not sure if this is worth it, but gives the plotting library a slightly more self-contained feel.

Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this and do agree it's a QoL improvement, but want to raise the point that learning Hail's plotting library is not sufficient for someone's visualization needs - a user needs to learn bokeh (or something else), or will feel extremely constrained by the narrow set of things Hail can do at the moment. I do worry that hiding bokeh in this way will preempt that learning process.

I think we should merge this, but want to hear your thoughts first.

@cseed
Copy link
Contributor Author

cseed commented Feb 7, 2019

I agree completely. I certainly don't think we can hide or replace Bokeh (I hope the explicit emphasis on Bokeh in the documentation makes this clear), but I think we should continue to add common-case utilities to hl.plot life easier for users (and ourselves).

@cseed cseed dismissed tpoterba’s stale review February 7, 2019 00:36

addressed comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants