Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delimiter option to TableExport #5272

Merged
merged 4 commits into from Feb 6, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Feb 5, 2019

fixes #5271

@tpoterba tpoterba force-pushed the table-export-delimiter branch from 8be73fd to 9f1d765 Feb 5, 2019
}(sb += '\n')

""
case TableExport(_, path, typesFile, header, exportType, delimiter) =>
Copy link
Collaborator

@danking danking Feb 5, 2019

TableExport is not present in IRSuite.scala so this isn't tested.

Copy link
Collaborator

@danking danking Feb 5, 2019

Can you add it there?

Copy link
Collaborator Author

@tpoterba tpoterba Feb 6, 2019

oof, yeah

@tpoterba tpoterba dismissed danking’s stale review Feb 6, 2019

added tests

danking
danking approved these changes Feb 6, 2019
Copy link
Collaborator

@danking danking left a comment

I'm good with this if it passes tests.

@danking danking merged commit df63a39 into hail-is:master Feb 6, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants