Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delimiter option to TableExport #5272

Merged
merged 4 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@tpoterba
Copy link
Collaborator

commented Feb 5, 2019

fixes #5271

@tpoterba tpoterba force-pushed the tpoterba:table-export-delimiter branch from 8be73fd to 9f1d765 Feb 5, 2019

}(sb += '\n')

""
case TableExport(_, path, typesFile, header, exportType, delimiter) =>

This comment has been minimized.

Copy link
@danking

danking Feb 5, 2019

Collaborator

TableExport is not present in IRSuite.scala so this isn't tested.

This comment has been minimized.

Copy link
@danking

danking Feb 5, 2019

Collaborator

Can you add it there?

This comment has been minimized.

Copy link
@tpoterba

tpoterba Feb 6, 2019

Author Collaborator

oof, yeah

added tests

tpoterba added some commits Feb 6, 2019

@danking

danking approved these changes Feb 6, 2019

Copy link
Collaborator

left a comment

I'm good with this if it passes tests.

@danking danking merged commit df63a39 into hail-is:master Feb 6, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.