Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix persisting of vep, logistic regression, poisson regression #5416

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
4 participants
@tpoterba
Copy link
Collaborator

commented Feb 22, 2019

None of these methods were appropriately persisting, since the call was
in Scala. Since the Python IR was evaluated each time, the a new RVD
would be created and persisted on each call to backend.execute, and
the previous persisted RVDs would only be used once.

We need to be on the lookout for this pattern as we convert more
operations to MatrixToTableFunctions and friends

@tpoterba tpoterba assigned cseed and chrisvittal and unassigned cseed Feb 22, 2019

@cseed

cseed approved these changes Feb 22, 2019

[bugfix] Fix persisting of vep, logistic regression, poisson regression
None of these methods were appropriately persisting, since the call was
in Scala. Since the Python IR was evaluated each time, the a new RVD
would be created and persisted on each call to backend.execute, and
the previous persisted RVDs would only be used once.

We need to be on the lookout for this pattern as we convert more
operations to MatrixToTableFunctions and friends

@tpoterba tpoterba force-pushed the tpoterba:fix-vep-persisting branch from ad3c8fa to de095be Feb 22, 2019

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2019

Oh, good catch. This is something we can also test for in the performance test suite: compute and use twice.

@cseed cseed assigned cseed and unassigned chrisvittal Feb 22, 2019

@tpoterba tpoterba changed the title Fix persisting of vep, logistic regression, poisson regression [bugfix] Fix persisting of vep, logistic regression, poisson regression Feb 22, 2019

@danking danking merged commit fda6041 into hail-is:master Feb 22, 2019

1 check passed

hail-ci-0-1 successful build
Details

@tpoterba tpoterba deleted the tpoterba:fix-vep-persisting branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.