Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpers to create and remove k8s secrets for gcp sa keys #5569

Merged
merged 3 commits into from Mar 9, 2019

Conversation

@danking
Copy link
Collaborator

danking commented Mar 8, 2019

These scripts wrap gcloud and kubectl to provide one line commands to create and remove k8s secrets, with a standard name scheme, for GCP service accounts.

@danking danking requested a review from jigold Mar 8, 2019
namespace=$2
private_key_id=$(kubectl get secret gcp-sa-key-${service_account_name} \
-o json \
--namespace=test \

This comment has been minimized.

Copy link
@jigold

jigold Mar 8, 2019

Collaborator

namespace should be a variable not test

@danking danking dismissed jigold’s stale review Mar 8, 2019

adressed

@jigold
jigold approved these changes Mar 9, 2019
@danking danking merged commit 61a2083 into hail-is:master Mar 9, 2019
1 check passed
1 check passed
hail-ci-0-1 successful build
Details
@danking danking deleted the danking:gcp-k8s-sa-management branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.