* Added interactive scatter and joint plots in experimental #5601
Conversation
Both of these support a number of features not available in hail.plot: - interactive legend (click to hide/show elements) - labelling with continuous expressions - labelling using multiple expressions (will display a dropdown selection widget) - specifying color schemes - hovering on points displays their coordinates, labels and additional source fields - legend is also displayed outside of the plotting space to be unobtrusive
|
the whole plot module is experimental, so those can just go there (they're certainly documented just fine too!) can we just replace the default scatter with this one? |
|
Sure, the interface is slightly different though to accommodate for some of the new features. It also doesn't support passing python lists instead of hail expr -- could be trivially added if useful though. |
|
I think that's fine! |
|
OK, I've moved it and made the interface as close as I could to the previous |
hail/python/hail/plot/plots.py
Outdated
| List of x-values to be plotted. | ||
| y : :class:`.NumericExpression` | ||
| List of y-values to be plotted. | ||
| label : Dict[str, :class:`.Expression`] |
There was a problem hiding this comment.
would it be hard to extend this to support the original interface of label=mt.population?
There was a problem hiding this comment.
No, that was trivial actually! I've pushed a revised version that supports this. I did not add support for List[label] though (this was used when providing python lists rather than hail exp.
There was a problem hiding this comment.
Actually, in the same vein, let me return a Figure in case no label or a single label is passed.
There was a problem hiding this comment.
Done! So this is now mostly back compatible
There was a problem hiding this comment.
I could re-add the legend option to if desired
* Renamed fields to be as close as possible to previous scatter plot names * Added marker size option Removed unused import + space from experimental/plots
* Small join_plot change: assign gray color to missing factors in provided color palette rather than throwing an error
fixed import fixed scatter header
lfrancioli
force-pushed
the
experimental_plots
branch
from
1d5cf07
to
a182417
Compare
- `source_fields` -> `hover_fields` (clearer, same as `manhattan`) - removed `collect_all`, use `n_divisions is None` instead - Set `n_divisions` to previous default value of 500 everywhere
* small fixes, cleaning ups
* Fixed an issue with non-numeric, non-string types for hover fields
* Also corrected indentation of scatter doc
|
I'm not sure you signed up for this haha |
|
Hahaha, I really did not! Had a bunch of things that were working that I wanted to add to experimental, and then someone suggested I should just replace plot.scatter instead 😛 |
|
😉 |
Both of these support a number of features not available in hail.plot: