Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Extend import_table missing parameter to support multiple v… #5614

Merged
merged 5 commits into from Mar 19, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Mar 15, 2019

…alues

Fixes #5612

@@ -22,7 +22,7 @@ case class TextTableReaderOptions(
typeMapStr: Map[String, String],
comment: Array[String],
separator: String,
missing: String,
missing: Array[String],
Copy link
Collaborator

@danking danking Mar 18, 2019

this feels like the sort of thing that should be a java.util.Set.

Copy link
Collaborator Author

@tpoterba tpoterba Mar 18, 2019

thank you for your logic and reason

Copy link
Collaborator

@danking danking left a comment

LGTM, though I didn't realize py4j would figure out the set to scala Set thing

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Mar 18, 2019

no py4j here - it's using case class json deserialization

@danking danking merged commit 5482c53 into hail-is:master Mar 19, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants