Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Extend import_table missing parameter to support multiple v… #5614

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@tpoterba
Copy link
Collaborator

commented Mar 15, 2019

…alues

Fixes #5612

@@ -22,7 +22,7 @@ case class TextTableReaderOptions(
typeMapStr: Map[String, String],
comment: Array[String],
separator: String,
missing: String,
missing: Array[String],

This comment has been minimized.

Copy link
@danking

danking Mar 18, 2019

Collaborator

this feels like the sort of thing that should be a java.util.Set.

This comment has been minimized.

Copy link
@tpoterba

tpoterba Mar 18, 2019

Author Collaborator

thank you for your logic and reason

tpoterba added some commits Mar 18, 2019

@danking
Copy link
Collaborator

left a comment

LGTM, though I didn't realize py4j would figure out the set to scala Set thing

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

no py4j here - it's using case class json deserialization

fix

@danking danking merged commit 5482c53 into hail-is:master Mar 19, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.