[feature] Extend import_table missing parameter to support multiple v… #5614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
previously requested changes
Mar 18, 2019
| comment: Array[String], | ||
| separator: String, | ||
| missing: String, | ||
| missing: Array[String], |
Contributor
There was a problem hiding this comment.
this feels like the sort of thing that should be a java.util.Set.
Contributor
Author
There was a problem hiding this comment.
thank you for your logic and reason
danking
approved these changes
Mar 18, 2019
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
LGTM, though I didn't realize py4j would figure out the set to scala Set thing
Contributor
Author
|
no py4j here - it's using case class json deserialization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alues
Fixes #5612