[hail] Teach MatrixTable how to HTML#5677
Merged
Merged
Conversation
danking
force-pushed
the
matrixtable-html
branch
from
950cdc5 to
c9158fd
Compare
Contributor
Author
|
kind of curious what @konradjk will think of this |
danking
force-pushed
the
matrixtable-html
branch
2 times, most recently
from
fe0e3ba to
a697a93
Compare
Collaborator
|
What happens if there are column fields? |
Contributor
|
this doesn't show column fields. I think show should treat both scopes symmetrically. |
Contributor
Author
|
By default neither column nor row fields are displayed. PR's welcome that add an option to display them with the table header :) |
Contributor
|
oh, OK, that is symmetric |
Contributor
Author
|
to be clear, there is an option to display row fields, but it defaults to There's a lot of visual noise if you show both. |
danking
force-pushed
the
matrixtable-html
branch
from
a697a93 to
fc52a0c
Compare
danking
force-pushed
the
matrixtable-html
branch
from
fc52a0c to
58a8dc0
Compare
chrisvittal
approved these changes
Apr 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacks on #5666
Teaches Matrix Tables how to HTML