Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Teach MatrixTable how to HTML #5677

Merged
merged 3 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@danking
Copy link
Collaborator

commented Mar 22, 2019

stacks on #5666

Teaches Matrix Tables how to HTML

Screen Shot 2019-03-22 at 3 36 44 PM

Screen Shot 2019-03-22 at 3 36 37 PM

Screen Shot 2019-03-22 at 3 36 29 PM

Screen Shot 2019-03-22 at 3 36 34 PM

@danking danking force-pushed the danking:matrixtable-html branch from 950cdc5 to c9158fd Mar 22, 2019

@danking

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2019

kind of curious what @konradjk will think of this

@danking danking force-pushed the danking:matrixtable-html branch 2 times, most recently from fe0e3ba to a697a93 Mar 22, 2019

@chrisvittal
Copy link
Collaborator

left a comment

fix failing test

@konradjk

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

What happens if there are column fields?

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

this doesn't show column fields. I think show should treat both scopes symmetrically.

@danking

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 26, 2019

By default neither column nor row fields are displayed. PR's welcome that add an option to display them with the table header :)

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

oh, OK, that is symmetric

@danking

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 26, 2019

to be clear, there is an option to display row fields, but it defaults to False.

There's a lot of visual noise if you show both.

@danking danking force-pushed the danking:matrixtable-html branch from a697a93 to fc52a0c Mar 27, 2019

@danking danking force-pushed the danking:matrixtable-html branch from fc52a0c to 58a8dc0 Apr 4, 2019

@danking danking merged commit ccf316d into hail-is:master Apr 5, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.