Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Teach MatrixTable how to HTML #5677

Merged
merged 3 commits into from
Apr 5, 2019

Conversation

danking
Copy link
Contributor

@danking danking commented Mar 22, 2019

stacks on #5666

Teaches Matrix Tables how to HTML

Screen Shot 2019-03-22 at 3 36 44 PM

Screen Shot 2019-03-22 at 3 36 37 PM

Screen Shot 2019-03-22 at 3 36 29 PM

Screen Shot 2019-03-22 at 3 36 34 PM

@danking
Copy link
Contributor Author

danking commented Mar 22, 2019

kind of curious what @konradjk will think of this

@danking danking force-pushed the matrixtable-html branch 2 times, most recently from fe0e3ba to a697a93 Compare March 22, 2019 22:32
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix failing test

@konradjk
Copy link
Collaborator

What happens if there are column fields?

@tpoterba
Copy link
Contributor

this doesn't show column fields. I think show should treat both scopes symmetrically.

@danking
Copy link
Contributor Author

danking commented Mar 26, 2019

By default neither column nor row fields are displayed. PR's welcome that add an option to display them with the table header :)

@tpoterba
Copy link
Contributor

oh, OK, that is symmetric

@danking
Copy link
Contributor Author

danking commented Mar 26, 2019

to be clear, there is an option to display row fields, but it defaults to False.

There's a lot of visual noise if you show both.

@danking danking merged commit ccf316d into hail-is:master Apr 5, 2019
@danking danking deleted the matrixtable-html branch December 18, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants