Skip to content

[bugfix] Fix duplicated nodes in maximal_independent_set output#5692

Merged
danking merged 2 commits intohail-is:masterfrom
tpoterba:mis-distincnt
Apr 3, 2019
Merged

[bugfix] Fix duplicated nodes in maximal_independent_set output#5692
danking merged 2 commits intohail-is:masterfrom
tpoterba:mis-distincnt

Conversation

@tpoterba
Copy link
Contributor

Fixes #5535

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to distinct before the if too. Neither case should produce duplicates

@tpoterba
Copy link
Contributor Author

won't this require keying (and therefore shuffling) then?

@catoverdrive
Copy link
Contributor

@danking this PR is showing up as approved on the CI, but not as approved here.

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 1, 2019

github API troubles?

cseed
cseed previously requested changes Apr 3, 2019
Copy link
Contributor

@cseed cseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to get the CI unstuck.

@cseed
Copy link
Contributor

cseed commented Apr 3, 2019

This fixes the CI: #5757. I will dismiss my review after that goes in.

@danking
Copy link
Contributor

danking commented Apr 3, 2019

won't this require keying (and therefore shuffling) then?

@tpoterba yeah but that's the correct answer no?

@danking
Copy link
Contributor

danking commented Apr 3, 2019

Heh, this is all my fault: https://github.com/hail-is/hail/pull/5078/files

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 3, 2019

yeah, the keyed=False path is for performance and I'm OK leaving that with duplicated nodes

@danking
Copy link
Contributor

danking commented Apr 3, 2019

@tpoterba if you're good with the verbiage I added to the notes, then I'll approve.

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 3, 2019

ya

@danking danking merged commit 61a0751 into hail-is:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants