Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix duplicated nodes in maximal_independent_set output #5692

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@tpoterba
Copy link
Collaborator

commented Mar 26, 2019

Fixes #5535

@danking
Copy link
Collaborator

left a comment

this needs to distinct before the if too. Neither case should produce duplicates

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 26, 2019

won't this require keying (and therefore shuffling) then?

disagree

@catoverdrive

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

@danking this PR is showing up as approved on the CI, but not as approved here.

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 1, 2019

github API troubles?

@cseed
Copy link
Collaborator

left a comment

Requesting changes to get the CI unstuck.

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

This fixes the CI: #5757. I will dismiss my review after that goes in.

#5757 merged

@danking

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

won't this require keying (and therefore shuffling) then?

@tpoterba yeah but that's the correct answer no?

@danking

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 3, 2019

yeah, the keyed=False path is for performance and I'm OK leaving that with duplicated nodes

@danking

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

@tpoterba if you're good with the verbiage I added to the notes, then I'll approve.

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 3, 2019

ya

@danking

danking approved these changes Apr 3, 2019

@danking danking merged commit 61a0751 into hail-is:master Apr 3, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.