import_matrix_table can import matrix table with no cols#5723
import_matrix_table can import matrix table with no cols#5723danking merged 4 commits intohail-is:masterfrom
Conversation
| | Line: | ||
| | ${ line.truncate }""".stripMargin | ||
| ) | ||
| off = addType(fieldTypes(ii))(line, rowNum, ii, off) |
There was a problem hiding this comment.
Your test looks good. How does this change accomplish what you wanted? It looks like a simple reorder to me.
There was a problem hiding this comment.
The old way, we were checking that the line hadn't ended after every row field was added, which means that for something with no columns, we were checking that the line hadn't ended... at the end of the line.
This way, we're doing the check before adding each row field, so we'll only throw an error if we expect to be able to add another field and we can't. I think that's the only change necessary for this to work, but I wasn't able to get my dev env set up fully this week so I hadn't tested it locally.
|
@catoverdrive This looks like it's been running for 2 hours now. I would have expected it to be merged already as well. Could this cause an infinite loop -- you didn't test it locally correct? |
|
Just fixed it |
3 participants
Fixes #5718.