Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix unicode string ordering #5770

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Apr 3, 2019

No description provided.

Copy link
Contributor

@catoverdrive catoverdrive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment--otherwise it looks good.

@@ -1834,4 +1834,135 @@ class IRSuite extends SparkSuite {

assertEvalsTo(ir, 61L)
}

@Test def testfoo() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a super huge fan of this as a test---do we need it? (At the very least can we rename it?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops meant to delete it

@danking danking merged commit 2e632c6 into hail-is:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants