Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] restore proper mendel_errors behavior #5855

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@chrisvittal
Copy link
Collaborator

commented Apr 10, 2019

New entry filtering semantics was removing children with no errors
leading to incorrect counts.

fixes #5786

[bugfix] restore proper mendel_errors behavior
New entry filtering semantics was removing children with no errors
leading to incorrect counts.

@chrisvittal chrisvittal force-pushed the chrisvittal:fix-medel-errors branch from 90f8598 to 5b02d49 Apr 10, 2019

@tpoterba
Copy link
Collaborator

left a comment

needs a test

@chrisvittal chrisvittal requested a review from tpoterba Apr 12, 2019

@chrisvittal

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

@tpoterba is what I changed the current test to sufficient?

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

yeah, verified that it fails on current master

Add children values to mendel_errors test
This incorrectly show NA for fam['Dad2', 'Mom2'].children on master, and
correctly shows 1 on this branch.

@chrisvittal chrisvittal force-pushed the chrisvittal:fix-medel-errors branch from 9c8db87 to 5706cc9 Apr 12, 2019

@danking danking merged commit 1bce6e2 into hail-is:master Apr 12, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.