Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] restore proper mendel_errors behavior #5855

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@chrisvittal
Copy link
Collaborator

@chrisvittal chrisvittal commented Apr 10, 2019

New entry filtering semantics was removing children with no errors
leading to incorrect counts.

fixes #5786

New entry filtering semantics was removing children with no errors
leading to incorrect counts.
Copy link
Collaborator

@tpoterba tpoterba left a comment

needs a test

@chrisvittal chrisvittal requested a review from tpoterba Apr 12, 2019
@chrisvittal
Copy link
Collaborator Author

@chrisvittal chrisvittal commented Apr 12, 2019

@tpoterba is what I changed the current test to sufficient?

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Apr 12, 2019

yeah, verified that it fails on current master

This incorrectly show NA for fam['Dad2', 'Mom2'].children on master, and
correctly shows 1 on this branch.
@danking danking merged commit 1bce6e2 into hail-is:master Apr 12, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants