Skip to content

Fix tuple nested in dict type will fail when calling to_spark()#5885

Merged
danking merged 2 commits intohail-is:masterfrom
tongda:master
Apr 17, 2019
Merged

Fix tuple nested in dict type will fail when calling to_spark()#5885
danking merged 2 commits intohail-is:masterfrom
tongda:master

Conversation

@tongda
Copy link
Copy Markdown
Contributor

@tongda tongda commented Apr 16, 2019

When putting tuple in dict type, it will fail to convert spark dataframe. The issue could be reproduce by:

ht = hl.utils.range_table(10)
ht = ht.annotate(nested=hl.dict({"tup": hl.tuple([ht.idx])}))
ht.to_spark()

This PR fix this issue.

tpoterba
tpoterba suggested changes Apr 16, 2019
View reviewed changes
Comment thread hail/src/main/scala/is/hail/expr/AnnotationImpex.scala Outdated
@tpoterba tpoterba self-assigned this Apr 16, 2019
@danking danking merged commit 96a8eee into hail-is:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tpoterba tpoterba tpoterba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tpoterba tpoterba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tongda @tpoterba @danking