Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update citation section #5915

Merged
merged 6 commits into from Apr 19, 2019

Conversation

Projects
None yet
4 participants
@danking
Copy link
Collaborator

commented Apr 19, 2019

@jbloom22

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

Looks great to me, but Cotton should have a look too.

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

It would be nice if the versions always point to the current version, but I don't quite know how to manage that in the README.

In spite of the Keras example, I object to being the only one listed here.

@danking

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 19, 2019

re: latest version, it's not too bad to add it to the checklist. However the DOI link does always point to the latest.

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

I guess I was afraid of somebody copying and pasting from the README. But if they're going to do that, they're not going to get right version anyway.

You don't know the release hash until it goes in, which is annoying.

@danking

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 19, 2019

@cseed got you covered, from a JAR install:

In [3]: print(hl.cite_hail_bibtex())                                                                                                         

@misc{Hail,
  author = {Hail Team},
  title = {Hail},
  howpublished = {\url{https://github.com/hail-is/hail/commit/8269129095ea}}
}

from pip:

In [3]: print(hl.cite_hail_bibtex())                                                                                                         

@misc{Hail,
  author = {Hail Team},
  title = {Hail},
  howpublished = {\url{https://github.com/hail-is/hail/releases/tag/0.2.13}}
}

In [4]: print(hl.cite_hail())                                                                                                                
Hail Team. Hail 0.2.13-81ab564db2b4. https://github.com/hail-is/hail/releases/tag/0.2.13.

@danking danking force-pushed the danking:update-readme branch from 31e1c1f to f78dfca Apr 19, 2019

@cseed

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

Thanks, @danking, very nice work.

@danking danking force-pushed the danking:update-readme branch from f78dfca to ad2c0d6 Apr 19, 2019

@danking danking merged commit 4f17421 into hail-is:master Apr 19, 2019

1 check passed

hail-ci-0-1 successful build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.