Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call htsjdk's disableOnTheFlyModifications do disable header repairs #6013

Merged
merged 2 commits into from May 1, 2019

Conversation

@marksantcroos
Copy link
Contributor

@marksantcroos marksantcroos commented May 1, 2019

Fixes #6012.

): VCFHeaderInfo = {
val codec = new htsjdk.variant.vcf.VCFCodec()
if (!repairHeader)
Copy link
Collaborator

@tpoterba tpoterba May 1, 2019

I'd be happier just turning this off in all cases without any parameterization. This has caused nothing but trouble in the past!

Copy link
Collaborator

@tpoterba tpoterba May 1, 2019

it certainly couldn't have been easy to find all the places we thread the parameters through, though! Nice work.

Copy link
Contributor Author

@marksantcroos marksantcroos May 1, 2019

@tpoterba I'm happy to remove the conditional, if you are ok with that, that simplifies things obviously.

Copy link
Collaborator

@tpoterba tpoterba May 1, 2019

yes, absolutely.

@tpoterba tpoterba self-assigned this May 1, 2019
@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented May 1, 2019

fixes #2822 🎉 🎉 🎉

@marksantcroos marksantcroos changed the title Expose htsjdk's disableOnTheFlyModifications as repair_header Call htsjdk's disableOnTheFlyModifications do disable header repairs May 1, 2019
@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented May 1, 2019

Awesome, thanks for the contribution!

@danking danking merged commit dac090e into hail-is:master May 1, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants