[hail][feature] Expose binary_search for numeric arrays.
#6123
Conversation
| if not c.can_coerce(elem.dtype): | ||
| raise TypeError(f"'binary_search': cannot search an array of type {array.dtype} for a value of type {elem.dtype}") | ||
| elem = c.coerce(elem) | ||
| return hl.switch(elem).when_missing(hl.null(hl.tint32)).default(_lower_bound(array, elem)) |
There was a problem hiding this comment.
Is this always the right behavior regarding missingness? Might there be cases where the array contains some missing values (at the end), and the user would want the first missing index in that case (or the length of the array if there are no missing values)?
Actually, there are more issues than that if the array can contain missing values. We want to say "if all elements in array are smaller than elem, the returned value is the length of array", but it's really "if all non-missing elements in array are smaller than elem, the returned value is the index of the first missing value", which might be surprising.
At the least, we might make a warning about surprising behavior when the array contains missing values.
There was a problem hiding this comment.
I think this is the right interface for general use, but others might disagree so perhaps we should mark this experimental for now. A warning sounds appropriate.
No description provided.