Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Add 'compression' parameter to export_block_matrices #6349

Merged
merged 2 commits into from Jun 20, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Jun 13, 2019

No description provided.

Copy link
Contributor

@johnc1231 johnc1231 left a comment

Looks good to me. Sorry about the slow reply, just found out about scorecard 👍

Loading

@julirsch
Copy link

@julirsch julirsch commented Jun 20, 2019

It would be awesome if we could get this merged today @tpoterba @johnc1231 !

Loading

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Jun 20, 2019

random test failure...

Loading

@danking danking merged commit 5d8ca30 into hail-is:master Jun 20, 2019
1 check passed
Loading
@julirsch
Copy link

@julirsch julirsch commented Jun 21, 2019

@tpoterba would it also be possible to provide a parameter to limit the number of digits after the decimal? for example, digits = 8 would correspond to an output of 1.00000000

Loading

@tpoterba
Copy link
Collaborator Author

@tpoterba tpoterba commented Jun 21, 2019

yeah, sure, will make an issue

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants