Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] harmonize Expression.show with other shows #6404

Merged
merged 3 commits into from Jun 20, 2019

Conversation

@danking
Copy link
Collaborator

commented Jun 19, 2019

I removed the two default arguments so they use the same automatic sizing technology as MT and T show. I'm calling this a bugfix because it's confusing that they were different. I also doubt anyone will be broken by this change.

This also adds n_rows and n_cols which is useful for mt.GT.show where you want to specify a number of columns.

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Expression.anything is experimental (and documented as such) anyhow

@danking danking merged commit fe6df45 into hail-is:master Jun 20, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.