[hail] Simplify nested insert fields #6456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
previously requested changes
Jun 25, 2019
|
|
||
| case InsertFields(struct, Seq(), _) => struct | ||
|
|
||
| case Let(x, InsertFields(insertedChild, insFields, ord1), InsertFields(Ref(x2, _), fields, ord2)) if x2 == x && { |
Contributor
There was a problem hiding this comment.
I really want tests that would be bad to rewrite and check that we get the expected value. Is it hard to add that?
Contributor
Author
There was a problem hiding this comment.
will give it a go, yeah
tpoterba
force-pushed
the
simplify-nested-inserts
branch
from
089492c to
9421f05
Compare
Contributor
Author
|
added tests and narrowed the match. I had a bug that generated invalid IR if the |
danking
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.