Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Remove RegionValueArraySum aggregator. #6473

Merged
merged 3 commits into from Jun 26, 2019

Conversation

@tpoterba
Copy link
Collaborator

commented Jun 25, 2019

Replaced by generic AggArrayPerElement.

Test

@benchmark
def table_aggregate_array_sum():
    N = 10_000_000
    M = 100
    ht = hl.utils.range_table(N)
    ht.aggregate(hl.agg.array_sum(hl.range(0, M)))

Timings

Master:

Mean, Median: 7.71s, 7.74s

Branch:

Mean, Median: 4.99s, 4.99s
[hail] Remove RegionValueArraySum aggregator.
Replaced by generic AggArrayPerElement.

Test
----

```python
@benchmark
def table_aggregate_array_sum():
    N = 10_000_000
    M = 100
    ht = hl.utils.range_table(N)
    ht.aggregate(hl.agg.array_sum(hl.range(0, M)))
```

Timings
-------

Master:

```
Mean, Median: 7.71s, 7.74s
```

Branch:

```
Mean, Median: 4.99s, 4.99s
```
@jigold

jigold approved these changes Jun 25, 2019

tpoterba added some commits Jun 25, 2019

Fix

@danking danking merged commit 196cdd8 into hail-is:master Jun 26, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.