[hail] add lambda GC calculation#6498
Merged
Merged
Conversation
konradjk
changed the title
tpoterba
previously requested changes
Jun 27, 2019
| med_chisq = hl.agg.approx_quantiles(chisq, 0.5) | ||
| else: | ||
| med_chisq = hl.median(hl.agg.collect(chisq)) | ||
| return t.aggregate(med_chisq / hl.qchisqtail(0.5, 1)) |
Contributor
There was a problem hiding this comment.
can we separate the bit that generates the agg expression out into a separate private function? We have an open feature request to print the lambda GC in hl.plot.qq
tpoterba
previously approved these changes
Jun 27, 2019
tpoterba
previously requested changes
Jun 27, 2019
Contributor
tpoterba
left a comment
tpoterba
left a comment
There was a problem hiding this comment.
add to docs rst file(s)
Contributor
|
add to genetics.rst |
Contributor
|
also add experimental note since this is untested |
tpoterba
previously requested changes
Jun 27, 2019
|
|
||
| Note | ||
| ---- | ||
| This method is experimental. |
Contributor
There was a problem hiding this comment.
oops sorry this is what I meant:
.. include:: ../_templates/experimental.rst
tpoterba
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added
table_sourcesince I couldn't find it - let me know if I missed it