Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] add lambda GC calculation #6498

Merged
merged 4 commits into from Jun 28, 2019
Merged

[hail] add lambda GC calculation #6498

merged 4 commits into from Jun 28, 2019

Conversation

konradjk
Copy link
Collaborator

Also added table_source since I couldn't find it - let me know if I missed it

@konradjk konradjk changed the title Adding lambda GC calculation [hail] add lambda GC calculation Jun 27, 2019
med_chisq = hl.agg.approx_quantiles(chisq, 0.5)
else:
med_chisq = hl.median(hl.agg.collect(chisq))
return t.aggregate(med_chisq / hl.qchisqtail(0.5, 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we separate the bit that generates the agg expression out into a separate private function? We have an open feature request to print the lambda GC in hl.plot.qq

tpoterba
tpoterba previously approved these changes Jun 27, 2019
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to docs rst file(s)

@tpoterba
Copy link
Contributor

add to genetics.rst

@tpoterba
Copy link
Contributor

also add experimental note since this is untested


Note
----
This method is experimental.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry this is what I meant:

    .. include:: ../_templates/experimental.rst

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty!

@danking danking merged commit fe8e543 into hail-is:master Jun 28, 2019
@konradjk konradjk deleted the lambdagc branch June 28, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants