[hail] use val for IndexedRVDSpec partitioner#6629
Merged
danking merged 2 commits intohail-is:masterfrom Jul 12, 2019
Merged
Conversation
When using indexed reads, we were creating a new partitioner for every partiton in tmpPartitioner. It was not good.
Contributor
|
oof, this is bad enough we might want to do yet another release |
tpoterba
suggested changes
Jul 12, 2019
Contributor
tpoterba
left a comment
tpoterba
left a comment
There was a problem hiding this comment.
add a benchmark that will catch this performance problem
Collaborator
Author
|
You have no idea. I went from waiting over an hour for a stage to begin to fast enough. |
Collaborator
Author
|
This uses an undocumented feature. It can wait for a little while. |
Contributor
|
oh, phew, it's only on readIndexed |
Collaborator
Author
|
Yeah. |
tpoterba
approved these changes
Jul 12, 2019
chrisvittal
force-pushed
the
indexedrvdspec-val-partitioner
branch
from
7a44673 to
bfd521a
Compare
Collaborator
Author
|
This benchmark is in some ways bad. The real problem is in the compiler/orchestration, not in any execution. I feel like we need a |
Contributor
|
yeah, I agree. But we can also get that effect by having tiny data but big pipelines |
Xophmeister
added a commit
to wtsi-hgi/hgi-cloud
that referenced
this pull request
Aug 5, 2019
To address hail-is/hail#6629
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using indexed reads, we were creating a new partitioner for every
partiton in tmpPartitioner. It was not good.