Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move load/store methods onto Region object #6644

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@catoverdrive
Copy link
Collaborator

commented Jul 15, 2019

I've left all the instances of region.loadX untouched (and left the methods on the region object, but this should let us avoid piping through region objects when we just need to read something.

(Broken out from #6580)

@catoverdrive

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

oops---there's also a couple of logging methods in here that aren't used, but are handy to have for tests/debugging. Can move onto a separate PR if desired, but they're pretty small/straightforward.

@catoverdrive catoverdrive force-pushed the catoverdrive:region-stuff branch from dcfea89 to ba10948 Jul 15, 2019

@chrisvittal

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

It's fine. They were already there.

@danking danking merged commit 019d574 into hail-is:master Jul 15, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.