Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] only convert row keys into Java objects in PCA #6666

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@iitalics
Copy link
Contributor

commented Jul 17, 2019

fixes #6236

instead of calling SafeRow to manifest the entire row and then pick out the keys, create UnsafeRows and then copy only the keys.

added RVD.toUnsafeRows

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

nice!

@tpoterba tpoterba self-assigned this Jul 17, 2019

@tpoterba

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

too bad I haven't added a PCA benchmark yet :(

@danking danking merged commit 009fd22 into hail-is:master Jul 17, 2019

1 check passed

ci-test success
Details

@iitalics iitalics deleted the iitalics:pca-copy-less branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.