Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Parameterize check on union_rows. Don't check in split_multi #6669

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Jul 17, 2019

When I timed the specific code block we hid behind the flag, it took
about 1.5 seconds on the benchmark dataset.

This check scales linearly with the number of samples, though, which is not great.

When I timed the specific code block we hid behind the flag, it took
about 1.5 seconds on the benchmark dataset.
@danking danking merged commit 205ba0f into hail-is:master Jul 18, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants