Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] [bugfix] Fix correctness bug in Table.order_by optimization #6757

Merged
merged 3 commits into from Jul 29, 2019

Conversation

@tpoterba
Copy link
Collaborator

commented Jul 29, 2019

hl.desc sorts could be instead sorted ascending in some cases.

[hail] [bugfix] Fix correctness bug in Table.order_by optimization
`hl.desc` sorts could be instead sorted ascending in some cases.
@iitalics

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

maybe we should make an issue to support this optimization for non-ascending orders?

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 29, 2019

maybe we should make an issue to support this optimization for non-ascending orders?

good idea.

@danking danking merged commit f091347 into hail-is:master Jul 29, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.