Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache blockmatrix type #6775

Merged
merged 8 commits into from Aug 1, 2019

Conversation

@johnc1231
Copy link
Contributor

commented Jul 31, 2019

This PR makes the BlockMatrixNativeReader's type a lazy val so that it doesn't keep going to disk.

4800x speedup on my filtering and exporting 300 block matrices example.

@tpoterba
Copy link
Collaborator

left a comment

There are other def typs that need to be lazy vals. Everything that's a def typ in BlockMatrixIR.scala certainly

@johnc1231

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

Ok, will do

Replaced others

johnc1231 added some commits Jul 31, 2019

@johnc1231 johnc1231 force-pushed the johnc1231:johnc-cache-blockmatrix-type branch from c2ddf87 to 3ad029a Aug 1, 2019

@danking danking merged commit 6fbb666 into hail-is:master Aug 1, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.