Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache blockmatrix type #6775

Merged
merged 8 commits into from Aug 1, 2019
Merged

Conversation

@johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Jul 31, 2019

This PR makes the BlockMatrixNativeReader's type a lazy val so that it doesn't keep going to disk.

4800x speedup on my filtering and exporting 300 block matrices example.

Copy link
Collaborator

@tpoterba tpoterba left a comment

There are other def typs that need to be lazy vals. Everything that's a def typ in BlockMatrixIR.scala certainly

Loading

@johnc1231
Copy link
Contributor Author

@johnc1231 johnc1231 commented Jul 31, 2019

Ok, will do

Loading

@johnc1231 johnc1231 dismissed tpoterba’s stale review Jul 31, 2019

Replaced others

@johnc1231 johnc1231 force-pushed the johnc-cache-blockmatrix-type branch from c2ddf87 to 3ad029a Aug 1, 2019
@danking danking merged commit 6fbb666 into hail-is:master Aug 1, 2019
1 check passed
Loading
@johnc1231 johnc1231 deleted the johnc-cache-blockmatrix-type branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants