[bugfix][hail][oops] fix region reference counting in new aggregators#6824
Merged
danking merged 3 commits intohail-is:masterfrom Aug 7, 2019
Merged
[bugfix][hail][oops] fix region reference counting in new aggregators#6824danking merged 3 commits intohail-is:masterfrom
danking merged 3 commits intohail-is:masterfrom
Conversation
Contributor
Author
|
@chrisvittal I hit a segfault on this PR in the decoder trying to do The weird thing is that it appears to be sporadic, since it successfully ran all 5 iterations of test 1 and was on the last iteration of test2, judging by the number of spark stages, and it ran successfully when I just ran it a second time. |
chrisvittal
previously requested changes
Aug 7, 2019
| } | ||
|
|
||
| REGIONMETHOD(void, Region, setNull)( | ||
| JNIEnv* env, |
2645bb1 to
c92d90b
Compare
Contributor
Author
|
(re: segfault---I haven't hit this again, and the place where I hit it leads me to believe I might have just been doing something totally dumb---like rebuilding the jar in the middle of this) |
chrisvittal
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled out a flag to cache in java, but accidentally got rid of the thing it was actually doing.
This should be fixed now; with a smaller test mt I'm seeing the number of allocated regions be consistent between combOps: