Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] [bugfix/feature] Fix min/max and NaN #6847

Merged
merged 5 commits into from Aug 9, 2019
Merged

Conversation

@tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Aug 9, 2019

Added nanmin and nanmax functions.

This was a headache.

Added `nanmin` and `nanmax` functions.
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
Take the minimum value:
Take the minimum value of values:
Copy link
Contributor

@iitalics iitalics Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*of arguments

Loading

hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Loading
Take the minimum value of arguments:
>>> hl.eval(hl.nanmin(1.1, 50.1, float('nan')))
1.1at d
Copy link
Contributor

@johnc1231 johnc1231 Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because of the at d here.

Loading

@danking danking merged commit c0e940f into hail-is:master Aug 9, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants