Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] [bugfix/feature] Fix min/max and NaN #6847

Merged
merged 5 commits into from Aug 9, 2019

Conversation

@tpoterba
Copy link
Collaborator

commented Aug 9, 2019

Added nanmin and nanmax functions.

This was a headache.

[hail] [bugfix/feature] Fix min/max and NaN
Added `nanmin` and `nanmax` functions.
@tpoterba tpoterba referenced this pull request Aug 9, 2019
4 of 4 tasks complete
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Take the minimum value:
Take the minimum value of values:

This comment has been minimized.

Copy link
@iitalics

iitalics Aug 9, 2019

Contributor

*of arguments

hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
hail/python/hail/expr/functions.py Outdated Show resolved Hide resolved
Take the minimum value of arguments:
>>> hl.eval(hl.nanmin(1.1, 50.1, float('nan')))
1.1at d

This comment has been minimized.

Copy link
@johnc1231

johnc1231 Aug 9, 2019

Contributor

Tests are failing because of the at d here.

@danking danking merged commit c0e940f into hail-is:master Aug 9, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.