[hail] hl.range supports a single argument #6903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the semantics of Python `range`. See docs for example.
tpoterba
reviewed
Aug 19, 2019
hail/python/hail/expr/functions.py
Outdated
| >>> hl.eval(hl.range(0, 10, step=3)) | ||
| [0, 3, 6, 9] | ||
|
|
||
| Notes | ||
| ----- | ||
| The range includes `start`, but excludes `stop`. | ||
|
|
||
| If provided exactly one argument, the argument is interpreted as `stop` and | ||
| `start` is set to zero. This matches the behavior Python's :func:`range`. |
There was a problem hiding this comment.
this will link back to this function
There was a problem hiding this comment.
If we want a link, I think it will need to be external. Python ranges live here: https://docs.python.org/3/library/stdtypes.html#ranges
There was a problem hiding this comment.
I just removed the link.
chrisvittal
requested changes
Aug 19, 2019
| self.assertRaisesRegex( | ||
| hl.utils.HailException, | ||
| 'Array range cannot have step size 0', | ||
| hl.eval(hl.range(0,1,0) |
hail/python/hail/expr/functions.py
Outdated
| >>> hl.eval(hl.range(0, 10, step=3)) | ||
| [0, 3, 6, 9] | ||
|
|
||
| Notes | ||
| ----- | ||
| The range includes `start`, but excludes `stop`. | ||
|
|
||
| If provided exactly one argument, the argument is interpreted as `stop` and | ||
| `start` is set to zero. This matches the behavior Python's :func:`range`. |
There was a problem hiding this comment.
If we want a link, I think it will need to be external. Python ranges live here: https://docs.python.org/3/library/stdtypes.html#ranges
chrisvittal
reviewed
Aug 19, 2019
hail/python/hail/expr/functions.py
Outdated
| @@ -1910,6 +1916,9 @@ def range(start, stop, step=1) -> ArrayNumericExpression: | |||
| ------- | |||
| :class:`.ArrayInt32Expression` | |||
| """ | |||
| if stop is None: | |||
| stop = start | |||
| start = 0 | |||
There was a problem hiding this comment.
Also, this isn't an expression and causes type checking errors later.
>>> hl.range(10).show()
File "<string>", line 1, in <module>
File "</home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/decorator.py:decorator-gen-638>", line 2, in range
File "/home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/hail/typecheck/check.py", line 585, in wrapper
return __original_func(*args_, **kwargs_)
File "/home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/hail/expr/functions.py", line 1922, in range
return apply_expr(lambda sta, sto, ste: ArrayRange(sta, sto, ste), tarray(tint32), start, stop, step)
File "/home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/hail/expr/expressions/typed_expressions.py", line 3646, in apply_expr
indices, aggregations = unify_all(*args)
File "/home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/hail/expr/expressions/base_expression.py", line 225, in unify_all
new_indices = Indices.unify(*[e._indices for e in exprs])
File "/home/cdv/.cache/venv/hail/lib64/python3.6/site-packages/hail/expr/expressions/base_expression.py", line 225, in <listcomp>
new_indices = Indices.unify(*[e._indices for e in exprs])
AttributeError: 'int' object has no attribute '_indices'
chrisvittal
approved these changes
Aug 23, 2019
added 2 commits
August 26, 2019 12:30
chrisvittal
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the semantics of Python
range. See docs for example.