Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hailctl dataproc modify --update-hail-version #6919

Merged
merged 7 commits into from Aug 28, 2019

Conversation

@johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Aug 21, 2019

Running the command hailctl dataproc modify --update-hail-version will update the version of hail running on the cluster to the version you're currently running locally.

So if user has a cluster already and we tell them to update hail, they can just do:

pip install hail -U
hailctl dataproc modify my-cluster --update-hail-version

This PR resolves #6674

@danking
Copy link
Collaborator

@danking danking commented Aug 21, 2019

Yeah, modify the PR description to include one of the auto-closing keywords applied to the PR.

Loading

@danking
Copy link
Collaborator

@danking danking commented Aug 21, 2019

Loading

wheel = None
if args.update_hail_version:
if not pkg_resources.resource_exists('hailtop.hailctl', "deploy.yaml"):
raise RuntimeError(f"package has no 'deploy.yaml' file")
Copy link
Collaborator

@danking danking Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer assertion over if-raise. Users interpret AssertionError with no message as "go talk to the devs" but may interpret RuntimeError with message as their fault.

Loading

@danking danking merged commit 29d71e0 into hail-is:master Aug 28, 2019
1 check passed
Loading
@johnc1231 johnc1231 deleted the johnc-modify-update-hail-version branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants