hailctl dataproc modify --update-hail-version #6919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah, modify the PR description to include one of the auto-closing keywords applied to the PR. |
Contributor
danking
previously requested changes
Aug 22, 2019
| wheel = None | ||
| if args.update_hail_version: | ||
| if not pkg_resources.resource_exists('hailtop.hailctl', "deploy.yaml"): | ||
| raise RuntimeError(f"package has no 'deploy.yaml' file") |
Contributor
There was a problem hiding this comment.
Prefer assertion over if-raise. Users interpret AssertionError with no message as "go talk to the devs" but may interpret RuntimeError with message as their fault.
danking
approved these changes
Aug 28, 2019
…31/hail into johnc-modify-update-hail-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the command
hailctl dataproc modify --update-hail-versionwill update the version of hail running on the cluster to the version you're currently running locally.So if user has a cluster already and we tell them to update hail, they can just do:
This PR resolves #6674