Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentally Quadratic Filter Block Matrices #6948

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@johnc1231
Copy link
Contributor

commented Aug 26, 2019

Two separate quadratic things here, the one that mattered was the repeated calls to contains, but I fixed both anyway.

johnc1231 added 2 commits Aug 26, 2019
Construction of blockParentMap was accidentally quadratic since it re…
…peatedly called contains on a indexedSeq. Converted this to a set
@danking
Copy link
Collaborator

left a comment

Well that would do it.

@danking danking merged commit 0ee7eed into hail-is:master Aug 26, 2019

1 check passed

ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.