Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Implement memset with a while loop #7049

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@tpoterba
Copy link
Collaborator

commented Sep 12, 2019

Master:

2019-09-11 21:59:10,002: INFO: [1/1] Running split_multi_hts...
2019-09-11 21:59:44,299: INFO:     burn in: 34.29s
2019-09-11 22:00:15,875: INFO:     run 1: 31.57s
2019-09-11 22:00:47,900: INFO:     run 2: 32.02s
2019-09-11 22:01:19,140: INFO:     run 3: 31.24s

PR:

2019-09-11 21:56:22,833: INFO: [1/1] Running split_multi_hts...
2019-09-11 21:56:49,639: INFO:     burn in: 26.80s
2019-09-11 21:57:12,559: INFO:     run 1: 22.92s
2019-09-11 21:57:34,842: INFO:     run 2: 22.28s
2019-09-11 21:57:57,300: INFO:     run 3: 22.45s
@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 12, 2019

image

Why waste time set many byte when few byte do trick?

Copy link
Collaborator

left a comment

The fact that this is faster is so weird. Code is impossible.

@danking danking merged commit 35dda68 into hail-is:master Sep 12, 2019
1 check passed
1 check passed
ci-test success
Details
@chrisvittal

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Was this faster on everything?

@tpoterba tpoterba referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.