Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail][bugfix] fix type requirements for MatrixUnionRows #7070

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@catoverdrive
Copy link
Collaborator

commented Sep 16, 2019

fixes #6931.

types.map(_.colKeyStruct).toSet.size == 1 &&
types.map(_.rowType).toSet.size == 1 &&
types.map(_.rowKey).toSet.size == 1 &&
types.map(_.entryType).toSet.size == 1

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Sep 20, 2019

Collaborator

This seems inefficient. It probably doesn't matter most of the time, but I think there are uses where children is quite large. What about

assert(children.tail.forall(child => compatible(child.typ, children.head.typ))
def compatible(t1: MatrixType, t2: MatrixType): Boolean = {
  t1.colKeyStruct == t2.colKeyStruct &&
    ...
}

This comment has been minimized.

Copy link
@catoverdrive

catoverdrive Sep 20, 2019

Author Collaborator

👍

@danking danking merged commit c129a13 into hail-is:master Sep 25, 2019
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.