Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] fix setNumParents bug in GroupedAggregator #7077

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

iitalics
Copy link
Contributor

i'm only partially sure this is correct but i believe it is. +1 to nStates didn't really make sense, and this causes my collect agg to work

@iitalics iitalics changed the title [hail] [wip] fix setNumParents bug in GroupedAggregator [hail] fix setNumParents bug in GroupedAggregator Sep 17, 2019
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in incoming PR catch this.

@danking danking merged commit 0e21ab9 into hail-is:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants