Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hail] Improve simplification of nested struct insertions #7082

Merged
merged 4 commits into from
Sep 19, 2019
Merged

[hail] Improve simplification of nested struct insertions #7082

merged 4 commits into from
Sep 19, 2019

Conversation

tpoterba
Copy link
Contributor

Master:

2019-09-18 10:57:21,316: INFO: [1/1] Running table_annotate_many_nested_dependence...
2019-09-18 10:58:18,144: INFO:     burn in: 56.82s
2019-09-18 10:59:09,182: INFO:     run 1: 51.03s
2019-09-18 10:59:59,688: INFO:     run 2: 50.50s
2019-09-18 11:00:52,745: INFO:     run 3: 53.05s
2019-09-18 11:01:46,129: INFO:     run 4: 53.38s

PR:

2019-09-18 11:02:42,403: INFO: [1/1] Running table_annotate_many_nested_dependence...
2019-09-18 11:02:44,261: INFO:     burn in: 1.85s
2019-09-18 11:02:45,562: INFO:     run 1: 1.30s
2019-09-18 11:02:46,734: INFO:     run 2: 1.17s
2019-09-18 11:02:47,898: INFO:     run 3: 1.16s
2019-09-18 11:02:49,048: INFO:     run 4: 1.14s

@tpoterba
Copy link
Contributor Author

er, let me add a test.

@tpoterba
Copy link
Contributor Author

fixed + added tests. ready for review.

@tpoterba
[hail] Improve simplification of nested struct insertions
c8d1e6f 
Master:
```
2019-09-18 10:57:21,316: INFO: [1/1] Running table_annotate_many_nested_dependence...
2019-09-18 10:58:18,144: INFO:     burn in: 56.82s
2019-09-18 10:59:09,182: INFO:     run 1: 51.03s
2019-09-18 10:59:59,688: INFO:     run 2: 50.50s
2019-09-18 11:00:52,745: INFO:     run 3: 53.05s
2019-09-18 11:01:46,129: INFO:     run 4: 53.38s
```

PR:
```
2019-09-18 11:02:42,403: INFO: [1/1] Running table_annotate_many_nested_dependence...
2019-09-18 11:02:44,261: INFO:     burn in: 1.85s
2019-09-18 11:02:45,562: INFO:     run 1: 1.30s
2019-09-18 11:02:46,734: INFO:     run 2: 1.17s
2019-09-18 11:02:47,898: INFO:     run 3: 1.16s
2019-09-18 11:02:49,048: INFO:     run 4: 1.14s
```
@tpoterba
fix tests
c8a41c6
@tpoterba
fix double insertion
bd2af11
@tpoterba
limit optimization
4fafaa8
@danking danking merged commit 2f3c79d into hail-is:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-schultz patrick-schultz patrick-schultz approved these changes

Assignees

@patrick-schultz patrick-schultz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpoterba @patrick-schultz @danking